Merged
Conversation
leanish
reviewed
Mar 13, 2025
| } | ||
| return val; | ||
| } else { | ||
| return arg; |
Author
There was a problem hiding this comment.
Built-in types, like String and similar
There was a problem hiding this comment.
aaaah, "native" types for which there isn't ParameterizedType information, got it
leanish
reviewed
Mar 13, 2025
| if (arg == null) { | ||
| // for Optional parameters null should be returned as Optional.empty() to show a request for a null value | ||
| // and not including the parameter in the query at all should be returned as null to show "undefined" value / not set | ||
| if ((p instanceof ParameterizedType && ((ParameterizedType) p).getRawType() == Optional.class)) { |
There was a problem hiding this comment.
so, it's assumed lines 141-147 will be executed before this in the recursion? and thus adding the "undefined" nulls there?
Author
There was a problem hiding this comment.
yes. Alternative could be to change arg-parameter from Object to use Optional or similar so the missing values could be represented through that, but I didn't explore that implementation.
leanish
approved these changes
Mar 13, 2025
leanish
left a comment
leanish
left a comment
There was a problem hiding this comment.
added 2 questions, but LGTM if the answer is "yes"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for binding to
java.util.Optionalparameters. Binding to Optional parameters allows implementing partial updates. With a partial update the mutate call can update only some of the Optional fields without needing to repeat all the existing values of an object.The mapping from an optional field in GraphQL schema that binds to
java.util.Optionalis the following:java.util.Optionalof the underlying typeOptional.emptyto signal the removal of a possibly existing value of the fieldundefinedso any possibly existing value(s) should not be modified